Bugfix for PostProcess Stats job #10282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agr
reviewed
Nov 25, 2024
agr
reviewed
Dec 14, 2024
agr
reviewed
Dec 14, 2024
agr
reviewed
Dec 16, 2024
jimmylewis
reviewed
Dec 16, 2024
|
@Lanaparezanin |
agr
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description: existing method was returning an extra entry for the path itself, which caused the job to break as it couldn't process the extra entry. This was due to changes in the storage account and the new SDK.
The new method handles the extra entry without affecting existing jobs. It ensures that only the relevant blobs are fetched, avoiding the extra entry that caused the job to break.
Delimiter details: the new SDK required a trailing slash in the path to function correctly. Without this trailing slash, the method would return an extra entry for the path itself.
Other changes are an update to ResolveUri, the existing method wasn't sending proper information of the path and this one is. This bug might be related to other jobs as well and fixing it might break things. I filed it here: https://github.com/orgs/NuGet/projects/21/views/1?filterQuery=milestone%3A%22Sprint+2024-12%22+assignee%3A%40me&pane=issue&itemId=89578571&issue=NuGet%7CEngineering%7C5723
Addresses https://github.com/orgs/NuGet/projects/21/views/1?filterQuery=milestone%3A%22Sprint+2024-11%22+assignee%3A%40me&pane=issue&itemId=64259916&issue=NuGet%7CEngineering%7C5445